Use source.LANG/text.LANG as language map fallbacks for ST 4

facelessuser / sublime-markdown-popups

Markdown popup dependency for Sublime

https://facelessuser.github.io/sublime-markdown-popups/

Other

112 stars 13 forks source link

Use source.LANG/text.LANG as language map fallbacks for ST 4 #133

Closed jfcherng closed 2 years ago

jfcherng commented 2 years ago

Probably resolves https://github.com/facelessuser/sublime-markdown-popups/issues/102 @rchl @rwols

Answer to concerns in #102:

This feature is activated if and only if sublime.find_syntax_by_scope, which is introduced in the very first ST 4 dev build, is available.
Since this is a fallback, users can still set the correct dialect in the language map if that's what they want.
Language map is still preferred and there is no need to maintain two version of mdpopups or language map.

facelessuser commented 2 years ago

Thanks for doing this. I will evaluate and let you know my thoughts. I appreciate the approach to making this a fallback. I feel doing this as a "Hail Mary pass" when we are desperate to find a suitable language due to missing entries in the mapping is a fair approach.

facelessuser commented 2 years ago

The last thing we need is to update documentation on this. I'm thinking that overall this looks good.

facelessuser commented 2 years ago

@gir-bot lgtm

facelessuser commented 2 years ago

I'll go ahead and merge this and play around with it locally. I don't see any big concerns, so it is quite likely to make it into the next release.