facelessuser / sublime-markdown-popups

Markdown popup dependency for Sublime
https://facelessuser.github.io/sublime-markdown-popups/
Other
112 stars 13 forks source link

Add typst #143

Closed istudyatuni closed 4 months ago

istudyatuni commented 5 months ago

See https://github.com/sublimelsp/LSP/issues/2472

Follow-up https://github.com/hyrious/typst-syntax-highlight/pull/44

Not sure about typstcode name

facelessuser commented 5 months ago

I think for more of these obscure languages, I would prefer not to use file extensions. I'm okay with typst and typstcode. There are so many languages, and we may run into conflicts in the future. I usually like to see what other highlighters use for common language codes. Currently, I've only found Pygments which just uses typst. I'm not sure of the differences in tystcode vs typst, but I think we will limit it to using those specific names.

istudyatuni commented 4 months ago

Pygments which just uses typst

If I understand correctly, typst is not identifier for code blocks, that's just language identifier

what other highlighters use for common language codes

Github uses typ

#let a = 5

typc is only used in language servers for typst

I'm not sure of the differences in tystcode vs typst

By default this is markup, but can be switched to "code mode". .typc by itself is not used as scripting language though

What do you think about leaving only typc? I'm not sure about using long names

facelessuser commented 4 months ago

They use typst too. typ is likely a shorthand

#let a = 5
istudyatuni commented 4 months ago

What do you think about leaving only typc? I'm not sure about using long names

So what do you think about it? But maybe leaving only typc (without typ) is bad idea

facelessuser commented 4 months ago

After doing a little more research on what other highlighters do, we can keep typst and typ for typst, but I'd like typstcode and typc for typst code. If I ever have to pick between file extension conflicts in the future, is like this language to have a supported fallback. For now, that makes these extension both available with a more explicit fallback.

istudyatuni commented 4 months ago

I added typstcode

istudyatuni commented 4 months ago

How are changes from this projects landed? Is this integrated in sublime, so will be available in next release, or shipped as package?

facelessuser commented 4 months ago

When I tag the next release, it will be propagated up through package control.