search

facelessuser / sublime-markdown-popups

Markdown popup dependency for Sublime
https://facelessuser.github.io/sublime-markdown-popups/
Other
112 stars 13 forks source link

Wrong mapping for TypeScript :D #57

Closed predragnikolic closed 6 years ago

predragnikolic commented 6 years ago

Hello I noticed a wrong mapping TypeScript. I have TypeScriptSyntax installed.

Here instead of 'TypeScriptSyntax/TypeScript' should be 'TypeScript Syntax/TypeScript'.

>>> view.settings().get('syntax')
'Packages/TypeScript Syntax/TypeScript.tmLanguage'

This issue is realated to tomv564/LSP#383

Before the change it was like this. 2018-08-09-112406_683x384_scrot And after changing. 2018-08-09-112340_683x384_scrot

facelessuser commented 6 years ago

I'll take a look at this sometime soon. Sorry I missed this.

predragnikolic commented 6 years ago

No problem.

But when you get to this, maybe you could also add support for rust in the mapping file?

That's all from me for now.

facelessuser commented 6 years ago

If you find me the syntax to add for rust, if I'd be happy to look at it.

predragnikolic commented 6 years ago

I just added this line 'rust': (('rs', 'rust'), ('Rust/Rust',)), to the lang_map variable in the st_mapping.py file.

predragnikolic commented 6 years ago

Sorry accidentally pressed ctrl+shift+enter. Apparently that shortcut leaves a comment, and closes the issue.
Just wanted to say that the full name of the syntax for rust is 'Packages/Rust/Rust.sublime-syntax'.

facelessuser commented 6 years ago

Cool. I try to get to it when I can, but pull requests are also welcome.