search

facelessuser / sublime-markdown-popups

Markdown popup dependency for Sublime
https://facelessuser.github.io/sublime-markdown-popups/
Other
112 stars 13 forks source link

CSS filter causes exception #94

Closed willrowe closed 4 years ago

willrowe commented 4 years ago

When I pass the following to the css argument none of the styles are applied and mdpopups: Failed to retrieve scheme CSS! is output to the console.

.counter {
    {{ ".foreground" | css('color') | fade(0.25) }}
    font-size: .8em;
}
facelessuser commented 4 years ago

@willrowe, what version of ST are you on? And what color scheme are you on?

I just found a small bug, at least with recent Sublime versions. Apparently, Sublime no longer returns things like italic and bold every time you call style_for_scope, but now it includes them only if they apply. After fixing that, {{ ".foreground" | css('color') | fade(0.25) }} started working for me again:

Screen Shot 2020-08-12 at 8 27 38 AM

What I didn't see was the mdpopups: Failed to retrieve scheme CSS!, so I'd like to try your color scheme to see if there is an issue there.

willrowe commented 4 years ago

ST build 4081. It was working fine up until the last couple of builds. The color scheme is DA Dark from DA UI.

facelessuser commented 4 years ago

Cool, let me try that real quick.

facelessuser commented 4 years ago

@willrowe Sorry, that is an old scheme no longer publicly available. I'd have to get a link to it to test it.

willrowe commented 4 years ago

I'll have to test it after the fix you mentioned is released and see if that fixes it.

facelessuser commented 4 years ago

🤷

facelessuser commented 4 years ago

I deleted that scheme long ago. But I can't debug without the scheme.

willrowe commented 4 years ago

I really like it, it's unfortunate that they removed it. I need to find a new one that is maintained at some point. Thanks for taking a look, I will report back after testing the next release.

facelessuser commented 4 years ago

Well, if there are issues, there will be nothing I can do if I can't debug it, but I'll get a release out today anyways. If you have issues, and I can't debug, I'll have to close the issue regardless.

@gir-bot add S: more-info-needed

facelessuser commented 4 years ago

3.7.3 has been tagged, you should be able to update via Satisfy Dependencies command. Scheme parsing bugs will require me to debug scheme parsing, which I'm happy to do, but I'll need a failing scheme.

As far as things go right now, I am able to use filters without issues as the regression has been fixed that I experienced.

willrowe commented 4 years ago

That fixed it! Thanks so much for taking a look so quickly.

facelessuser commented 4 years ago

Glad you got it working. Wish I had caught that bug a bit sooner.