search

facetoe / zenpy

Python wrapper for the Zendesk API
GNU General Public License v3.0
340 stars 162 forks source link

fix users.me #608

Closed ahmedsabriz closed 9 months ago

ahmedsabriz commented 9 months ago

users.me API stopped working with curser pagination introduction as it does not support it and needs to be manually set to False.

cryptomail commented 9 months ago

Ok I'll possibly add some tests here this is pretty bad. Thanks for catching it.

cryptomail commented 9 months ago

I have some administravia to do today but will do this by close of business today.

cryptomail commented 9 months ago

Also, there may be another way to fix this that may make more sense..... :) Either way, I'll have a look today.

cryptomail commented 9 months ago

Thank you for your contribution. I added a test to help guard against any regressions. Please see commit history (namely this....) https://github.com/facetoe/zenpy/pull/611 I have subsequently bumped the version as well to 2.0.43 Please test :)

cryptomail commented 9 months ago

Again, thank you for your contribution. I will close this PR as I have taken your fix and added a commensurate test.