search

facetoe / zenpy

Python wrapper for the Zendesk API
GNU General Public License v3.0
344 stars 162 forks source link

Allow to delete and redact attachments #639

Closed nerg4l closed 2 months ago

nerg4l commented 3 months ago

Resolves #350

Regarding tests, unfortunately, I could not figure out how to add related tests.

cryptomail commented 3 months ago

https://github.com/facetoe/zenpy/pull/637#issuecomment-2297161278 FYI Hang tight.

cryptomail commented 2 months ago

ok I can start looking at this now

cryptomail commented 2 months ago

I am superceding this PR with https://github.com/facetoe/zenpy/pull/643

cryptomail commented 2 months ago

I need to ensure the redaction endpoint works with tests.

nerg4l commented 2 months ago

If you could share some additional information or an example PR, then I can provide tests next time. For me at least, the current tests are not easily understandable.

cryptomail commented 2 months ago

Got you covered.