search

facetoe / zenpy

Python wrapper for the Zendesk API
GNU General Public License v3.0
344 stars 162 forks source link

Fixes Issue #647: Allow for notify_subscribers param #652

Closed cryptomail closed 2 months ago

cryptomail commented 2 months ago

Fixes Issue #647: Allow for notify_subscribers param

cryptomail commented 2 months ago

@ahmedsabriz If you got this branch and pip installed with pip uninstall zenpy then

pip install -e .

And you tried: self.zenpy_client.help_center.articles.create

  1. Shutting off subscriber notifications with the new parameter notify_subscribers True
  2. Shutting off subscriber notifications with the new parameter notify_subscribers False
  3. 'Shutting off subscriber notifications with the new parameter notify_subscribers Absent

Please let me know if it works.

I tested on my instance but I'm not 100% sure it mails the author of the section if the article is also written by that same author heh

cryptomail commented 2 months ago

Just tested this an instance where I am migrating HC. Notifications are sent if notify_subscriber is True or absent. When it is set to False, I did not get any notifications as end-user subscriber.

Thanks you so much.

Thank you for your affirmation. I will take this out of draft and begin the integration process.