search

faceyspacey / babel-plugin-dual-import

NOTE: now use babel-plugin-universal-import if you're using React Universal Component
MIT License
51 stars 11 forks source link

Remove deprecated attributes and add preload #7

Closed sshrshnv closed 7 years ago

sshrshnv commented 7 years ago

@faceyspacey what about remove charset and type attributes for link and script tags? They are not needed for html5. And it's good to add preload

faceyspacey commented 7 years ago

I just copied what webpack was doing when they inject dynamic imports.

I'm not sure charset and type will make much difference removing them. As for preload, that also seems irrelevant since these links are only added to the page after initial load:

https://developer.mozilla.org/en-US/docs/Web/HTML/Preloading_content

I could be wrong though.