search

faceyspacey / react-universal-component

🚀 The final answer to a React Universal Component: simultaneous SSR + Code Splitting
MIT License
1.7k stars 80 forks source link

react-refresh support/replacement for react-hot-loader #212

Open JustFly1984 opened 4 years ago

JustFly1984 commented 4 years ago

I'm using react-universal-component in multiple gatsby.js projects. Current version of gatsby.js made switch from hot-reload to better supported by React react-refresh

I've updating the codebase, and stumble upon yarn install warning:

warning "react-universal-component > react-hot-loader@4.12.20" has unmet peer dependency "@types/react@^15.0.0 || ^16.0.0".

And I got curious if it react-hot-loader dependency of react-universal-component could break or conflict with react-refresh some way.

PS: I do not care much about @types/react missing peer dependency, as @types/react-dom has it as direct dependency.

OliverJAsh commented 4 years ago

AFAICS react-hot-loader is not actually used in the source code, so I'm not sure why it's listed as a dependency. It was added in https://github.com/faceyspacey/react-universal-component/commit/3c21ffa45c7bd9cc9dca5066243ecbcda004ad2a#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R97.