search

faceyspacey / redux-first-router-demo

Kick-Ass Universal RFR Demo That Answers Your SSR + Splitting Questions
MIT License
126 stars 46 forks source link

Fixes for SEO with basename #22

Closed re6exp closed 7 years ago

re6exp commented 7 years ago

Changed to match the redux-first-router#rudy API. Notice: Need to create new branch in demo repository!

faceyspacey commented 7 years ago

Thanks for all this. Going through it now.

Why is the hmr changed, particularly to have reload=true?

Also, why do we need a peer dep of history? I'm thinking of removing it as a peer dep and removing its dep here.

re6exp commented 7 years ago

It's my fault, I overlooked that. I played with them and forgave to revert. Yep, it should be removed from there.

faceyspacey commented 7 years ago

ok this is done, it's now as the rudy branch here:

https://github.com/faceyspacey/redux-first-router-demo/tree/rudy

we'll merge to master when rudy is done. im going to close this PR as i did it separately since merging this would have merged to master. Thanks again!

re6exp commented 7 years ago

Thank you, James!