search

faceyspacey / redux-first-router-demo

Kick-Ass Universal RFR Demo That Answers Your SSR + Splitting Questions
MIT License
126 stars 46 forks source link

[CHORE] Updating `onBeforeChange` args to match latest RFR api. #31

Closed BrendanFDMoore closed 6 years ago

BrendanFDMoore commented 6 years ago

This PR updates the example onBeforeChange usage in the connectRoute options to account for the fact that the next action is now wrapped in an outer bag object with other data. The goal is to reduce unexpected behaviour for new RFR users :children_crossing: .

See note 9/9 in README: https://github.com/faceyspacey/redux-first-router/blob/rudy/README.md#L23 Diff: https://github.com/faceyspacey/redux-first-router/commit/012dbfa65288b99d2c10e8c6face1c6d9c46cc7d

Relates to: https://github.com/faceyspacey/redux-first-router-demo/issues/30

faceyspacey commented 6 years ago

thanks for this!