search

facg3 / chemics

0 stars 1 forks source link

Adding code in code review time #22

Open ZooeyMiller opened 6 years ago

ZooeyMiller commented 6 years ago

We've talked about this repeatedly. Commits 170e4ac80db74d357b1ad59a5d5867ae88b35a90 & cc6da16a2f605969bfaababa5abc402954321073 were pushed way after 8am this morning. This time is for code review, it's not acceptable to be pushing to your own repo in this time.

Not only were these commits pushed in code review time, they were pushed directly to master. We should not have to be raising issues on this in week 4. Don't do it again.

yahyaHB commented 6 years ago

it was some few details just to make the heruko link woks

ZooeyMiller commented 6 years ago

@yahyaHB I know it was just a small change, but it's more the principle. Code review time is the only time in the course that we give you to fully focus on another group's project. Even if it's something as small as a heroku link, it shows that you're not properly giving attention to the team you are code reviewing's project.

Remember it's not a competition, and the issues raised are learning opportunities. If something isn't done in time for code review, then so be it, just fix it in the time we dedicate to respond to issues.