facil-io / cstl

facil.io C STL - a Server Toolbox Library for C, including JSON processing, hash maps, dynamic arrays, binary strings and more.
https://facil.io
MIT License
68 stars 6 forks source link

Improve compatibility if kill has been defined on Windows #11

Closed janbiedermann closed 1 year ago

janbiedermann commented 1 year ago

Problem occures when using fio-stl.h to write Ruby extensions on Windows because Ruby exposes its own kill.

boazsegev commented 1 year ago

Actually, since fio_thread_kill is the system specific wrapper, we don't need a kill patch at all... I just forgot to delete the code from patches.h 😅👍🏻

janbiedermann commented 1 year ago

Alright, now master fio-stl.h works fine for me for Ruby extensions. Fantastic, thanks!