search

facile-it / mongodb-bundle

Bundle service integration of official mongodb/mongo-php-library
MIT License
35 stars 16 forks source link

Add maximum depth to serializer to prevent infinite recursion (#167) #171

Open mhvis opened 2 months ago

mhvis commented 2 months ago

Fixes #167

I'm not sure if this is a good approach. Other suggestions are welcome.

Thanks for reacting to the issue @ilario-pierbattista and thanks for creating this great library.

The issue doesn't really have a high priority, as one shouldn't put circular objects into a Mongo database anyway. So if you don't want to merge this or don't want to fix the issue I can totally understand.

ilario-pierbattista commented 2 months ago

thank @mhvis for you contribution.

Thanks for reacting to the issue @ilario-pierbattista and thanks for creating this great library.

Just to make things clear, @Algatux is the original author of the bundle and a lot of @facile-it folks and external contributors maintain it. Kudos should go to @Algatux and all the other contributors as well, you included 🎉

I'll give it a quick look right now, even if it's not highest priority.