search

facile-it / paraunit

Run PHPUnit tests in parallel
https://engineering.facile.it/paraunit/
Apache License 2.0
135 stars 14 forks source link

ProcessBuilderFactory improve deprecated symfony code #117

Closed LoopKarma closed 6 years ago

Jean85 commented 6 years ago

Hi there, thanks for your contribution! Unfortunately, I cannot use this, because Paraunit is compatible with symfony/console back to v2.8, where the ProcessBuilder is needed due to the different behavior of the basic Process class. Paraunit should also currently be able to switch to the new behavior under Symfony 4, using the ProcessFactoryInterface. It's implemented both by ProcessFactory and ProcessBuilderFactory (the deprecated one).

Sorry to have wasted your time.

LoopKarma commented 6 years ago

@Jean85 no worries, thank you for the feedback