search

facile-it / paraunit

Run PHPUnit tests in parallel
https://engineering.facile.it/paraunit/
Apache License 2.0
135 stars 14 forks source link

Handle PHPUnit --stderr option #144

Closed pczerkas closed 4 years ago

pczerkas commented 4 years ago

Fix for tests, which depend on PHPUnit's --stderr option in order to stop PHPUnit from sending headers. E.g. functional test is using session_id() in setUp() to manipulate session ID.

Without --stderr option passed to phpunit such test is failing with "headers already sent" due to PHPUnit's outputing on STDOUT.

Jean85 commented 4 years ago

Also, you should merge or rebase master to fix the build.

pczerkas commented 4 years ago

Hi Alessandro, I've made the requested changes. Please review them:)

For the changelog entry - please add it, because I don't know in what version the changes would be relesed.

Jean85 commented 4 years ago

Thank you for your contribution! I left the PHP 7.1 issue alone, I'll be dropping it in #149 soon.