search

facile-it / paraunit

Run PHPUnit tests in parallel
https://engineering.facile.it/paraunit/
Apache License 2.0
138 stars 15 forks source link

feat: allow PHPUnit 11 #225

Closed Chris53897 closed 8 months ago

Chris53897 commented 8 months ago

https://github.com/facile-it/paraunit/issues/226

Jean85 commented 8 months ago

PHPUnit 11 does not support PHP 8.1, but you still have failure there too: https://github.com/facile-it/paraunit/actions/runs/7754078301/job/21146669794?pr=225#step:6:11

I suspect the build is broken on the main branch too.

Chris53897 commented 8 months ago

Thanks for working on this https://github.com/facile-it/paraunit/pull/227

Jean85 commented 8 months ago

Wow, incredible! After making the base build green with #227, it works flawlessly without any change!

I'll add a changelog entry and release it!

Chris53897 commented 8 months ago

perfect, thanks

kubawerlos commented 8 months ago

it works flawlessly without any change!

@Jean85 that's because PHPUnit was not allowed after all.

PHPUnit 11 requires phpunit/php-code-coverage:^11.0: https://github.com/sebastianbergmann/phpunit/blob/11.0.0/composer.json#L35

Which is not allowed: https://github.com/facile-it/paraunit/blob/2.3.0/composer.json#L30

Jean85 commented 8 months ago

Aw crap, my fault! I didn't check that 11 was effectively running...

kubawerlos commented 8 months ago

I'm on it: https://github.com/facile-it/paraunit/pull/228

Jean85 commented 8 months ago

Watch out, there's #229 too, and I've already posted a comment there.