[Refactoring][log parser] ParserCompilerPass

facile-it / paraunit

Run PHPUnit tests in parallel

https://engineering.facile.it/paraunit/

Apache License 2.0

140 stars 15 forks source link

Closed ranpafin closed 8 years ago

ranpafin commented 8 years ago

Will use the container compiler functionality to add all chain elements to JSONParser.
Will make more explicit the existing order in the chain.

coveralls commented 8 years ago

Changes Unknown when pulling 68ac3bb0c88b01b9145c8701a378a41daee24f97 on 2110_tagged_parsers into \ on master**.

Jean85 commented 8 years ago

Thanks! Nice refactoring! Apart for my only comment, LGTM! :+1: Fix that and we're good to merge!

coveralls commented 8 years ago

Changes Unknown when pulling 5a377b23674bcdc24e3c43e8328c4a502002ebd5 on 2110_tagged_parsers into \ on master**.

coveralls commented 8 years ago

Changes Unknown when pulling c77c2648b827068590d0cb9a843a6b5effdf28c0 on 2110_tagged_parsers into \ on master**.

Jean85 commented 8 years ago

Thanks, that's great! Merging right now ;) And I think I'll disable Coverall's comments, they're broken! :frowning: The check is enough.

ranpafin commented 8 years ago

@Jean85 yeah probably something related to the branch not being master...

Jean85 commented 8 years ago