Update consistency in builders setters.

facile-it / php-openid-client

PHP OpenID Client

35 stars 7 forks source link

Update consistency in builders setters. #10

Closed drupol closed 3 years ago

drupol commented 3 years ago

In order to have a consistency across all the builders,

I propose to:

[x] Rename MetadataProviderBuilder::setClient() into MetadataProviderBuilder::setHttpClient()

thomasvargiu commented 3 years ago

I have some doubts about changing the http client setters and getters to "client". In our domain there is another entity named "client". @drupol @Jean85 what do you think?

drupol commented 3 years ago

I would use setHttpClient for sure to avoid any confusion.

thomasvargiu commented 3 years ago

Oh sorry, you're right, I read it in the wrong way 👍

drupol commented 3 years ago

Grazie a voi !