facile-it / php-openid-client

PHP OpenID Client
36 stars 7 forks source link

Fix build issue on Scrutinizer. #11

Closed drupol closed 3 years ago

drupol commented 3 years ago

This PR:

Jean85 commented 3 years ago

Do we really need Scrutinizer, since we already have Psalm at level 1 and a company suggested code style?

drupol commented 3 years ago

It's up to you to decide, I just provided the PR to transform the X in V.

I guess Scrutinizer is kept to have a test coverage badge and a code quality badge, at least, that's the only reason why I keep it myself on my own projects.

thomasvargiu commented 3 years ago

We can move on another coverage badge provider in the future. I'm going to merge this for the moment