Closed antonioeatgoat closed 1 year ago
Base: 59.89% // Head: 60.00% // Increases project coverage by +0.10%
:tada:
Coverage data is based on head (
9b3adca
) compared to base (b47e83d
). Patch coverage: 100.00% of modified lines in pull request are covered.:exclamation: Current head 9b3adca differs from pull request most recent head 69687af. Consider uploading reports for the commit 69687af to get more accurate results
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thanks @antonioeatgoat! Give me some time to fix psalm issues and I'll release it
Thank you @thomasvargiu for the very quick feedback!
Released in 0.3.3
Right now, if the well-known url provides an authorization endpoint containing a query, the
AuthorizationService
will build a wrong url, which will eventually contains the symbol?
twice.This PR adds the unit test to spot the case, so adds some checks on the uri generation in order to prevent the problem. Even better would be to have to separate tests, one for the uri containing params and one for the uri without params, but this is up to you.
I wasn't able to perform a
composer run psalm
before opening the PR since it looks broken, I am sorry.