search

facile-it / php-openid-client

PHP OpenID Client
35 stars 7 forks source link

Bump PSR-7 composer package versions, and update others. Add PHP 8.2 checks #28

Closed Prusias closed 1 year ago

Prusias commented 1 year ago

Hi,

We'd like to use this package, but our project is dependent on newer versions of certain packages also used by this package.

To fix this, I have updated the 'psr/http-message' and 'laminas/laminas-diactoros' packages in this package, but also in https://github.com/facile-it/php-jose-verifier. (For which I've made a separate pull request.)

This MR isn't ready to merge as is. The composer.lock isn't updated, and I've only tested it with our fork of the php-jose-verifier package. When the composer is updated, and the fork is used, psalm and PHPUnit pass the workflow. Also in PHP 8.2 as well.

Prusias commented 1 year ago

I'm not happy with adding the /** @psalm-suppress InvalidArgument */ lines in this MR, but I am not familiar enough with psalm to fix the issue. The called method takes an array with a shape that should be valid, but psalm doesn't recognize the second string in the array shape.

Jean85 commented 1 year ago

@thomasvargiu can you take care of this too?

thomasvargiu commented 1 year ago

Hi @Prusias, thanks for the PR. Can you rebase it? I've fixed the CI and there are some conflicts

thomasvargiu commented 1 year ago

@Prusias do you want me to take care of this?

Prusias commented 1 year ago

Hey @thomasvargiu, this pull request got closed automatically, I've added back the main change in a new one. https://github.com/facile-it/php-openid-client/pull/29

Unfortunately, I cannot easily spot the issues with psalm, and I don't want to make any drastic changes.