Unable to set static JWK's in client metadata due to missing 'return'

facile-it / php-openid-client

PHP OpenID Client

35 stars 7 forks source link

Unable to set static JWK's in client metadata due to missing 'return' #32

Closed cooperaj closed 9 months ago

cooperaj commented 9 months ago

https://github.com/facile-it/php-openid-client/blob/ba2b298140df6b70c2e1422447055b5623e78a56/src/Client/ClientBuilder.php#L89

When supplying a JWKs key to static client metadata it is silently ignored by the library as the line that gets hit by the conditional check does nothing. It should return the created JWK. Client Metadata derived JWKs are also similarly ignored by the same line.

thomasvargiu commented 9 months ago

😱 I guess it's not tested. I'm going to fix it ASAP. Thanks!

thomasvargiu commented 9 months ago

Fix released in 0.3.5. Thanks @cooperaj!