search

facilityregistry / fred-api

Facility Registry API Documentation Website
11 stars 4 forks source link

Rename url => href #46

Closed mortenoh closed 11 years ago

mortenoh commented 11 years ago

I think the url field should be renamed to href, this will keep it more in sync with what people are used to from other APIs.

bobjolliffe commented 11 years ago

+1

I guess this is also making explicit that the url should use http or https scheme, rather than file://, ftp:// or what have you. I think its a minor improvement.

On 7 March 2013 06:30, Morten Olav Hansen notifications@github.com wrote:

I think the url field should be renamed to href, this will keep it more in sync with what people are used to from other APIs.

— Reply to this email directly or view it on GitHubhttps://github.com/facilityregistry/fred-api/issues/46 .

mortenoh commented 11 years ago

I agree. On 7 Mar 2013 13:11, "bobjolliffe" notifications@github.com wrote:

+1

I guess this is also making explicit that the url should use http or https scheme, rather than file://, ftp:// or what have you. I think its a minor improvement.

On 7 March 2013 06:30, Morten Olav Hansen notifications@github.com wrote:

I think the url field should be renamed to href, this will keep it more in sync with what people are used to from other APIs.

— Reply to this email directly or view it on GitHub< https://github.com/facilityregistry/fred-api/issues/46> .

— Reply to this email directly or view it on GitHubhttps://github.com/facilityregistry/fred-api/issues/46#issuecomment-14551834 .

edjez commented 11 years ago

ok

rowenaluk commented 11 years ago

+1

rowenaluk commented 11 years ago

resolved on march 7 call

rowenaluk commented 11 years ago

no objections from anyone

mberg commented 11 years ago

Please don't close these until the api is updated to reflect these changes.. Updating API now.