search

facilityregistry / fred-api

Facility Registry API Documentation Website
11 stars 4 forks source link

errorMessage.code can be a number? #50

Closed mortenoh closed 11 years ago

mortenoh commented 11 years ago

Hi

It seems that in the spec message.code is required to be a string, since both the status code + status message is used.

Can/should this be changed to only status code? it makes sense, yes? If you want to say, "bla bla not found" you can do so in the message part.

ctford commented 11 years ago

But aren't status codes still strings? i.e. "200", not 200. You don't ever multiply or add them, for example.

mortenoh commented 11 years ago

I guess that's true. Don't feel strongly either way on it, just using the "CODE" should be fine.

Morten

On Wed, Mar 13, 2013 at 6:34 PM, Chris Ford notifications@github.comwrote:

But aren't status codes still strings? i.e. "200", not 200. You don't ever multiply or add them, for example.

— Reply to this email directly or view it on GitHubhttps://github.com/facilityregistry/fred-api/issues/50#issuecomment-14836374 .

edjez commented 11 years ago

Close as obsolete.

mberg commented 11 years ago

Allow code and message to be custom. Fix to make it valid json

mortenoh commented 11 years ago

I still think calling it a "error message" is wrong. The code should be what defines whether it is an informational service (as in when we are deleting) or an error.

edjez commented 11 years ago

Yup, the text just says "the message" now.