search

facioquo / stock-indicators-python

Stock Indicators for Python. Maintained by @LeeDongGeon1996
https://python.StockIndicators.dev
Apache License 2.0
248 stars 39 forks source link

Manual DLL update in Piplines #180

Closed LeeDongGeon1996 closed 2 years ago

LeeDongGeon1996 commented 2 years ago

We should consider updating DLL manually. In Piplines, using the latest DLL automatically can cause failure on tests because the DLL is not updated automatically in development environment. And that old DLL is used when new feature is committed. This interrupts tests for new feature and forces to order tasks to pass testcase.

DaveSkender commented 2 years ago

We’ll, it ensures that an official production copy is used (same version that was sent to NuGet) + it reminds us that it needs to be updated regularly, when it breaks 😀.

I’m okay with manual-only if those two condition can still be met.

LeeDongGeon1996 commented 2 years ago

Yeah, above two conditions are important, but this wrapper is still catching up C# implementation. So sometimes these condition disturb adding new feature(like #178). It would be also good if we enable auto-update dll after v1.0

LeeDongGeon1996 commented 2 years ago

Almost caught up C# implementation, so it's obsolete.