facioquo / stock-indicators-python

Stock Indicators for Python. Maintained by @LeeDongGeon1996
https://python.StockIndicators.dev
Apache License 2.0
220 stars 37 forks source link

docs: Update docs for v0.8.1 #247

Closed LeeDongGeon1996 closed 2 years ago

LeeDongGeon1996 commented 2 years ago

Description

Fixes #244

Checklist

LeeDongGeon1996 commented 2 years ago

Because from stock_indicators.indicators.common.enums import PivotPointType is shortened to from stock_indicators import PivotPointType in the docs, 4f9e2155b7faaaeeedd615f5dc01af08a743bbec has to be cherrypicked to the new branch from tag 0.8.0, and it's going to be released as 0.8.1 with patch-version up.

@DaveSkender I think I need a new branch from tag 0.8.0. Could you make it as a protected branch with named 0.8?

DaveSkender commented 2 years ago

I think I need a new branch from tag 0.8.0. Could you make it as a protected branch with named 0.8?

I’m not sure I follow this logic. Is this a rebase issue, or something we can just fix in a second commit (before releasing)?

LeeDongGeon1996 commented 2 years ago

I'd like to include only  4f9e215 in v0.8.1 (because it's related UX). But we are merging every PR to main till now. So there's no way to exclude some un-released commits before  4f9e215 . That's why I need a new branch to make a backport.

DaveSkender commented 2 years ago

I've created a branch v0.8 from that tag.