Closed LeeDongGeon1996 closed 1 year ago
It's gone to v2..😵.. do we need to reset commit to ae966438b1a3c7091637470c89393b6054910597?
It's gone to v2..😵.. do we need to reset commit to ae96643?
No, you probably added the semver tag on an individual commit, when it should really go in the commit message when you merge this PR, which is still registering at 0.9.x. I think it'll be fine when we merge with that tag again, since it will Squash that prior commit. Worst case is we fix the tags.
update: actually, looks like you did it right, see next note
I’d recommend:
main
IMO, we can keep original url in docs. Because the original url(https://daveskender.github.io/Stock.Indicators.Python) is permanent for us, while the new one(https://python.stockindicators.dev/) is also for us but can be changed in the future whatever the reason is. Anyway access to the original will be redirected to the new one. How do you think about it?
IMO, we can keep original url in docs. Because the original url(https://daveskender.github.io/Stock.Indicators.Python) is permanent for us, while the new one(https://python.stockindicators.dev/) is also for us but can be changed in the future whatever the reason is. Anyway access to the original will be redirected to the new one. How do you think about it?
Yah, that's a fair point. If I get hit by a bus and can't pay the domain fees, it could be a problem in the future; whereas the GitHub Pages URL should persist forever-ish. On the other hand, it might be confusing to be redirected too. Okay to keep, we can always revisit later.
Yeah, just just just in case haha
@DaveSkender (just for sharing my thought) I think it's better to use the new url to where the url is exposed in "form of URL", and use the original one to where the url is used for the link(such as inside <a>
tag in html)
Description
+semver: major
not worked before v1.Checklist