Closed LeeDongGeon1996 closed 9 months ago
GPT did it all...👍
@DaveSkender Can you check Azure Pipelines webhook config? It's staying on pending status.
~And are we going to keep using gitversion for deploying? or we can just tag and use tag as a package version.~
I configured that it can detect semver from git tag using setuptool_scm
.
I'm following this guide(Publishing package distribution releases using GitHub Actions CI/CD workflows) and it uses PyPI’s trusted publishing, Can you config for it? Also, it will be great if we can set deployment protection rules.
I've added the Trusted Publisher Management
for two new environments pypi
and pypi-test
. The former requires my review; whereas the later should be a bit more open for action.
Also, check for an equivalent auto-draft for the release notes after successful publish to pypi
environment, same or similar to:
Note: this may need to be configured slightly different if the timing of tagging is different. I didn't think through the scenario, so it may be okay with same implementation.
I've also removed the required check for the Azure Pipelines build, but will need to add the new CI.yml variant to the branch protection rules once everything's working well here, and probably after this is merged.
@DaveSkender Thanks for your work :)
The former requires my review; whereas the later should be a bit more open for action.
Yeah, that's why we need to set deployment protection rules or add review step before deployment
I really only have one question, how is the release tag introduced on main
?
How does the test.pypi.org
publish get its version number?
You're right! I'll draft fixed contributing.md
and then you correct that please.
setuptools_scm
does everything. It recognize the latest tag on repository. (AFAIK, it usesgit describe
)
If it's not incrementing a pre-release suffix, the publish will get rejected as a duplicate when you commit 2+ times to main
before introducing an actual new Tag. If it doesn't auto-increment, you can always add a x.x.x.{ github.run_id }
or something like that on it, if feasible.
(oops, sorry, edited your comment accidentally)
Yeah as I know, setuptool_scm resolve that problem by creating unique version number, let me double check.
I've just checked that it creates unique version number by every new commit.
Let me know when you're done with contributing.md
and I'll take an editorial pass on it.
Yeah, I've already done! You can merge after work is done.
Description
Fixes #319
Checklist