docs: Add blurb for trouble with converting to quotes

facioquo / stock-indicators-python

Stock Indicators for Python. Maintained by @LeeDongGeon1996

https://python.StockIndicators.dev

Apache License 2.0

226 stars 38 forks source link

docs: Add blurb for trouble with converting to quotes #352

Closed LeeDongGeon1996 closed 7 months ago

LeeDongGeon1996 commented 7 months ago

Description

Add blurb for trouble with converting to quotes

Checklist

[x] My code follows the existing style, code structure, and naming taxonomy
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have performed a self-review of my own code and included any verifying manual calculations
[x] I have added or updated unit tests that prove my fix is effective or that my feature works, and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
[x] My changes generate no new warnings and running code analysis does not produce any issues
[x] I have added or run the performance tests that depict optimal execution times
[x] I have made corresponding changes to the documentation

LeeDongGeon1996 commented 7 months ago

I've just add short blurb as we discussed and this is for general cases, not only for locale issue.

DaveSkender commented 7 months ago

I'm done tweaking, go ahead and merge if you're ready.

LeeDongGeon1996 commented 7 months ago

@DaveSkender do we have code coverage badge from Codacy now? I can't find with my permission.

DaveSkender commented 7 months ago

do we have code coverage badge from Codacy now? I can't find with my permission.

I've removed them from the permanent README.md aspects that get published with packages in #347, given how much trouble they've been. You probably can't see this settings page with the badge info.

[![Codacy Badge](https://app.codacy.com/project/badge/Coverage/2b48204b1e304e3bac977fbc92b19c14)](https://app.codacy.com/gh/DaveSkender/Stock.Indicators.Python/dashboard)

For the .NET site, I'd only put it on the contributing page.

LeeDongGeon1996 commented 7 months ago

given how much trouble they've been.

You mean showing this badge has had trouble frequently?

DaveSkender commented 7 months ago

You mean showing this badge has had trouble frequently?

It's just been hard to get them to work with Codacy
Legacy package manager pages that are permanent have old Azure DevOps badges that are now broken when I turn off those old builds; pages like on nuget.org and pypi.org -- don't want to make the same mistake if/when we move off of Codacy

LeeDongGeon1996 commented 7 months ago

@DaveSkender I added in the same page. Could you set ignoring some files like docs or tests in Codacy?

DaveSkender commented 7 months ago

@DaveSkender I added in the same page. Could you set ignoring some files like docs or tests in Codacy?

Updated: