search

facioquo / stock-indicators-python

Stock Indicators for Python. Maintained by @LeeDongGeon1996
https://python.StockIndicators.dev
Apache License 2.0
226 stars 38 forks source link

ROC is missing `Momentum` return value #353

Closed hmuhdkamran closed 7 months ago

hmuhdkamran commented 7 months ago

The problem

in indicator roc.py has missing momentum, you should add the following lines in it

Error message(s):

    @property
    def momentum(self) -> Optional[float]:
        return self._csdata.Momentum

    @momentum.setter
    def roc_sma(self, value):
        self._csdata.Momentum = value
DaveSkender commented 7 months ago

@LeeDongGeon1996 do you want to sneak this into your next release?

LeeDongGeon1996 commented 7 months ago

@hmuhdkamran Thank you for reporting. I'll include this feature in this release.

DaveSkender commented 7 months ago

This was implemented in v1.2.1