site still loads as PWA - Githubissues

facioquo / uswds-design-patterns

Design pattern Idea Book for the U.S. Web Design System

https://uswds.facioquo.com

Creative Commons Zero v1.0 Universal

1 stars 1 forks source link

site still loads as PWA #30

Closed DaveSkender closed 1 year ago

DaveSkender commented 1 year ago

After attempting to remove all of the progressive web app components in https://github.com/facioquo/uswds-design-patterns/commit/71dfd5c7b8ce04d4900492f9e7cbce086d069ea0. Use of PWA isn't necessarily a problem if it didn't cause style conflicts between site and design pattern pages; however, when removing it, these persist:

it shows an "install" option when deployed, likely due to a properly defined manifest.json file
notable page load flicker when navigating

Recommend:

[x] modify (simplify) manifest.json file, rename to root manifest.json
[x] add properly formatted maskable icons, including an SVG option (see manifest link)
[x] merge down to one root stylesheet with special class family?