search

fack2 / Dictionary-Giphy-App

0 stars 1 forks source link

stop using var #29

Open eadehemingway opened 5 years ago

eadehemingway commented 5 years ago

https://github.com/fack2/Dictionary-Giphy-App/blob/39e6b5004a4a7c48fe14c52a59feb453b8f3c4fa/public/js/dom.js#L29

var is lazy, decide if it should be let or const (most of the time its const)

sulieman1 commented 5 years ago

Issue fixed @eadehemingway

eadehemingway commented 5 years ago

there is still one var in dom.js! and at one point you have used let but you dont ever change the value of the variable so you should use const