search

facn2 / ApolloXII

Autocomplete Widget
1 stars 0 forks source link

Search function non pure? #46

Open m4v15 opened 7 years ago

m4v15 commented 7 years ago

Really nice modularisation of all your code, but you're search function relies on the food variable to work, so testing it you would also have to require in food - maybe pass it as a second variable to the function (JSONToSearchThrough?) and then you've got a nice neat, easily testable function.

m4v15 commented 7 years ago

relates #32

yvonne-liu commented 7 years ago

Yes! Thanks @m4v15 :sparkles: for clarifying on the pure function part too 👍