search

facn2 / knafeh

news for multiple countries
0 stars 3 forks source link

Calling the make URL function 'fetch' is confusing #39

Open m4v15 opened 7 years ago

m4v15 commented 7 years ago

Here in the test file

Fetch is normally a function that makes an API request, so this naming was a little confusing - maybe "makeFlagURL" or something

m4v15 commented 7 years ago

Also you have an actual fetch function in your API script so this is even more confusing