search

facn2 / knafeh

news for multiple countries
0 stars 3 forks source link

Your api key is on Github #41

Open m4v15 opened 7 years ago

m4v15 commented 7 years ago

Hide it

https://gist.github.com/derzorngottes/3b57edc1f996dddcab25

m4v15 commented 7 years ago

Obviously these keys are free and are not allowing access to anyones data, but in the future you will definitely be using keys which can give people access to sensitive information, so it is 100% best practice to do it anyway

tyeung2017 commented 7 years ago

yeah Mavis, we are aware of that and would not do it again.

We forgot about it and only remember this after a lot of commits pushed to github.