facn2 / knafeh

news for multiple countries
0 stars 3 forks source link

newsUrl2 is not a very good variable name #44

Open m4v15 opened 7 years ago

m4v15 commented 7 years ago

https://github.com/facn2/knafeh/blob/master/scripts/global.js#L3

Like, it might be if you had two news URL's and this was the second one, but even then you could be more specific.

However here, it's not even a second URL it's another part of the URL. Better practice might be to have baseURL, APIKeyURL, showFieldsURL as three parts of the URL