search

facn2 / knafeh

news for multiple countries
0 stars 3 forks source link

Dom manipulation functions #48

Open m4v15 opened 7 years ago

m4v15 commented 7 years ago

There's two files with dom manipulation in them - updateContent and createTemplate. I can see the reason for splitting them across files, but seeing as they are all dom manipulation, I would think about having them in the same file, or giving them both similar names - createDomElements, updateDomElements

m4v15 commented 7 years ago

In fact, thinking about it, I'm not sure you need the createTemplate functions - you could have the template hard coded into the HTML with no content, and then call update content immedietely with Israel?