Closed jjd9 closed 9 months ago
this is great, but please, split this in two, as you suggested. Let's postpone the bonxai_rviz_plugins to a subsequent PR
Ok, I split the PR into 3 (they are all here if you are interested: https://github.com/jjd9/Bonxai/pulls). I will close this PR and submit these one at a time (since they depend on each other).
Hello,
I hope I do not come off the wrong way submitting such a large PR to your repo :sweat_smile: I saw that you had "Rviz integration" as a TODO, and I thought that would be a lot of fun to do. :smiley: If this is too much to review as one PR though, or you think some of the organizational changes are not needed, please lmk and I can break it up and revert things where necessary.
This PR:
Bonxai/Bonxai
and can be built without any ros2 machinery, and the ros-y-ness is inBonxai/Bonxai_ros
. And Bonxai_ros is comprised of a few distinct ros packages.** This change regrettably makes the PR more challenging to review, but I did not feel good about simply inserting the msg definitions and rviz_plugin into the existing bonxai_ros package (as that has burned me in the past). However, if you would prefer that approach or have other ideas about how we could reorganize the ros aspects of the repo, please let me know and I would be happy to make those changes.