search

facontidavide / ros_type_introspection

Deserialize ROS messages that are unknown at compilation time
MIT License
61 stars 30 forks source link

[MSVC] Drop constexpr on absl::string_view to avoid build break #40

Closed seanyen closed 5 years ago

seanyen commented 5 years ago

When building ros_type_introspection on Windows by MSVC, the usage of constexpr on absl::string_view caused the following build break:

ros_type_introspection\include\ros_type_introspection/stringtree_leaf.hpp(102): error C2131: expression did not evaluate to a constant
abseil-cpp\abseil_cpp\absl/strings/string_view.h(186): note: a non-constant (sub-)expression was encountered

A similar issue was also reported on https://github.com/abseil/abseil-cpp/issues/352. For now, before a better solution comes out, I recommend to drop constexpr to avoid build break.

facontidavide commented 5 years ago

Thanks!