Closed valgur closed 1 week ago
Hi! This PR proposes a few minor tweaks to the CMakeLists.txt to simplify potential packaging as a Conan (a recipe draft) or Vcpkg package.
The changes:
install()
CMAKE_POSITION_INDEPENDENT_CODE
SHARED
cxx_std_17
set(CMAKE_CXX_STANDARD 17)
USING_ROS2
EXTERNAL_FASTCDR
target_link_libraries()
rapidjson
Also, for external use, would a rosx_introspection::rosx_introspection CMake target be ok or would you prefer a non-namespaced rosx_introspection?
rosx_introspection::rosx_introspection
rosx_introspection
looks good to me. Thanks for the help
Hi! This PR proposes a few minor tweaks to the CMakeLists.txt to simplify potential packaging as a Conan (a recipe draft) or Vcpkg package.
The changes:
install()
commands for the standalone C++ library.CMAKE_POSITION_INDEPENDENT_CODE
configurable.SHARED
builds.cxx_std_17
property instead ofset(CMAKE_CXX_STANDARD 17)
to make it easier to override the standard, if necessary.USING_ROS2
an explicit option.EXTERNAL_FASTCDR
option.target_link_libraries()
forrapidjson
.