Config units

[LukasNickel]

Allows to set units for the columns:

• pointing_az/zd
• source_az/zd
• delta

These can be set in the DISP config. Defaults are "deg" for all az/zd columns and "rad" for delta.

!! This will break the CTA analyses, because the explicit deg2rad(delta) is gone!! Your will need to specify the unit as "deg" as is done in the examples/config_source_cta.yaml.

Further ideas:

• Do we need units for focal length and camera coordinates (mm/m)?
• Do we want to specify the unit of the Energy (GeV/TeV)? If so: Would this be a global option?
• Are there any other columns that we need to watch out for?

ToDo:

• [x] add units for the angles and transform values
• [x] add unit for the focal length and transform values
• [x] add unit for the energy and use it for plotting labels
• [x] add tests for the DISP results -> not needed for now
• [x] add tests for the plot scripts -> #129

[maxnoe]

focal_length: yes energy: yes, but only needed for the plots (axis labels)

of the top of my head I think that's all, let me check

[maxnoe]

I added tests for the plotting scripts here: https://github.com/fact-project/aict-tools/pull/129

[maxnoe]

Testing disp results would be nice, but I also run the open_crab_sample_analysis before each release is made as an integration test. So at least the FACT chain is fully tested.

[LukasNickel]

I suppose the failing tests are related to the sklearn2pmml requirements, that you changed in #129 @MaxNoe ?

[maxnoe]

Yes

[maxnoe]

Actually, now with the master merged, also the plot_disp_performance was failing, fixed it.