search

fact-project / aict-tools

Reproducible Artificial Intelligence for Cherenkov Telescopes
MIT License
6 stars 6 forks source link

add scripts to train and apply dxdy based origin regressor #145

Closed ArnePoggenpohl closed 3 years ago

maxnoe commented 3 years ago

@ArnePoggenpohl tests are failing due to some wrong imports. You can run them locally using pytest -v

ArnePoggenpohl commented 3 years ago

@ArnePoggenpohl tests are failing due to some wrong imports. You can run them locally using pytest -v

I remove one old import from 'train_disp_regressor'. There is still one test failing ('test_to_dl3'), but since I haven't change anything in this file, I'm not sure why an error occurs.

maxnoe commented 3 years ago

@ArnePoggenpohl this was fixed in the current master, to update your branch here do on your branch:

git fetch
git merge origin/master
git push
maxnoe commented 3 years ago

@ArnePoggenpohl one missing import left, we get there

ArnePoggenpohl commented 3 years ago

Looks very good, thanks again. Only the storing of disp_prediction in apply_dxdy_model is I think misleading or not useful, so should be removed.

Thanks for finding this. It was something from the beginning, where I wanted to compare the variable disp_prediction between the two models, but in the final version it is not needed anymore.