Improve fact dl3 - Githubissues

fact-project / aict-tools

Reproducible Artificial Intelligence for Cherenkov Telescopes

MIT License

6 stars 6 forks source link

Improve fact dl3 #148

Closed maxnoe closed 3 years ago

maxnoe commented 3 years ago

Use ErfaAstromInterpolator for faster coordinate transformations in fact_to_dl3
Add az_prediction, zd_prediction columns (also for mc)
Fix parallelize_array_computation for n_job=1
Improve concatenating astropy time objects.

Verified everything is working by running the open crab sample analysis:

theta2_plot

maxnoe commented 3 years ago

the optimizations result in a nice factor of two improvement for the application on the open crab data, with the main time now spend in applying the machine learning models.

LukasNickel commented 3 years ago

There actually seems to be no astropy 4.2 for python 3.6. Do we want to keep on supporting 3.6? https://docs.astropy.org/en/stable/install.html

maxnoe commented 3 years ago

@LukasNickel, no we should just drop it. All major packages did that in their most recent versions following numpy: https://numpy.org/neps/nep-0029-deprecation_policy.html