search

fact-project / aict-tools

Reproducible Artificial Intelligence for Cherenkov Telescopes
MIT License
6 stars 6 forks source link

Add predictions in the altaz frame #152

Closed LukasNickel closed 3 years ago

LukasNickel commented 3 years ago

Connected Issue: #149

codecov-io commented 3 years ago

Codecov Report

Merging #152 (ba7dc7d) into master (fa057dc) will increase coverage by 0.16%. The diff coverage is 97.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
+ Coverage   90.42%   90.58%   +0.16%     
==========================================
  Files          37       37              
  Lines        3176     3241      +65     
==========================================
+ Hits         2872     2936      +64     
- Misses        304      305       +1
Impacted Files Coverage Δ
aict_tools/preprocessing.py 86.31% <92.00%> (+2.10%) :arrow_up:
aict_tools/configuration.py 87.42% <100.00%> (+0.15%) :arrow_up:
aict_tools/cta_helpers.py 91.66% <100.00%> (+4.16%) :arrow_up:
aict_tools/scripts/apply_disp_regressor.py 94.20% <100.00%> (+0.55%) :arrow_up:
aict_tools/scripts/apply_dxdy_regressor.py 95.45% <100.00%> (+0.37%) :arrow_up:
tests/test_cta_coords.py 100.00% <100.00%> (ø)
tests/test_executables.py 83.12% <100.00%> (+0.51%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fa057dc...ba7dc7d. Read the comment docs.

LukasNickel commented 3 years ago

Let's just call it {x,y,alt,zd,az}_prediction. Avoiding source.

Sure