search

fact-project / fact-tools

The fact-tools are an extension to the streams framework to analyse the data of the First G-APD Cherenkov Telescope.
http://sfb876.tu-dortmund.de/FACT/
GNU General Public License v3.0
6 stars 1 forks source link

Reimplement conc core #261

Closed maxnoe closed 6 years ago

maxnoe commented 6 years ago

This reimplements ConcCore without copying the MARS code verbatim and without sticking to 1 character variable names

maxnoe commented 6 years ago

No. See issue #74 . We do not really expect to have the same results.

I implemented this feature how it is described in the comments of MARS.

maxnoe commented 6 years ago

Comparison plots new and old on a Crab data run with ~18000 Events:

comparison1d comparison2d I think the results are similar enough and the Code is much easier to understand now.

dneise commented 6 years ago

Could you point to these conments in Mars you are refering to? Or, even better: point to the place in fact tools, where you explain what you define as ConcCore?

maxnoe commented 6 years ago

Could you point to these conments in Mars you are refering to? Or, even better: point to the place in fact tools, where you explain what you define as ConcCore?

In Fact-Tools this is now in the javadocs of the processor: https://github.com/fact-project/fact-tools/pull/261/files#diff-d2718c8d2e104928d3e18a591f16e42aR38

In Mars it's here:

https://trac.fact-project.org/browser/trunk/Mars/mimage/MHNewImagePar.h#L31

dneise commented 6 years ago

Ah okay, I get it now .. I must say I mixed the word "ConcCore" up with "ConcCOG" since Core is also a word which expresses something "centered" ... reading then that you count all pixels with a Maha-dist < 1 did not help me, since I did not know what you used for the covariance matrix ...

"inside the Hillas ellipsis" should have told me what was going on ...

I know you are not responsible for the term "ConcCore" which was basically what puzzled me and reading the docstring did not help me, but sent me to wikipedia, to study the Maha-dist, just to learn, that I am missing the information about the cov-matrix.