fact-project / fact-tools

The fact-tools are an extension to the streams framework to analyse the data of the First G-APD Cherenkov Telescope.
http://sfb876.tu-dortmund.de/FACT/
GNU General Public License v3.0
6 stars 1 forks source link

Remove unused, untested processors #294

Closed maxnoe closed 6 years ago

maxnoe commented 6 years ago
jebuss commented 6 years ago

I would vote for keeping those but adding unit tests and maybe find some to evaluate those.

fact.features.source.SourceLineTest is a cleaning method suggested by wolfgang. I think it was a good idea but it was never investigate further due to other priorities at that time. Could be an interesting BA.

fact.extraction.TimeGradientExtraction was an Idea for time extraction improvemment based on Sabrinas MA. Same as above.

fact.extraction.TimeOverThresholdTL is a nice tool if you want to investigate what is happening on you time series above a given threshold. However, I agree it would make sense to have an example for this. I think it would not hurt to keep it. Nevertheless, I also don't use it anymore.

maxnoe commented 6 years ago

@jebuss The reasons you state would be reasons for me to go forward removing those processors.

The code of SourceLineTest is not readable and the actual idea is not mentioned anywhere. It also looks like it doesn't work any more.

Same for the extraction things.

I don't think we should keep around ideas that were never tried or finished.

maxnoe commented 6 years ago

Oh, the TimeOverThresholdTL Processor actually head an example, so I keep it. But tests and better docs would be nice to have.

maxnoe commented 6 years ago

I added three more Processors (all cleaning)

maxnoe commented 6 years ago

@jebuss please comment