Gain service - Githubissues

fact-project / fact-tools

The fact-tools are an extension to the streams framework to analyse the data of the First G-APD Cherenkov Telescope.

http://sfb876.tu-dortmund.de/FACT/

GNU General Public License v3.0

6 stars 1 forks source link

Gain service #333

Closed maxnoe closed 6 years ago

maxnoe commented 6 years ago

Fixes #267

Introduces a new service which reads in a fits file with the gains of the single pe measurements
Fits file in the resources with values from 20130825 -- 20170917
If UnixTimeUTC is not in the date item, the defaultIntegralGains are used
warning if time difference between event and gain measurement is larger than 5 days

Question: can we create a file with a larger time range?

maxnoe commented 6 years ago

This is way I added the InterpolatePixelArray processor to the unit tests, the HillasParameterisation failed because photoncharge was -Infinity. Maybe we should just interpolate pixels with gain == 0 instead or on top of using the hardware service. But at least for the test data the broken pixels list worked fine.

maxnoe commented 6 years ago

Should we merge this now? Or should we wait until we can provide a file with larger time range? I would rather not put too many largish binary files in the history