search

fact-project / fact-tools

The fact-tools are an extension to the streams framework to analyse the data of the First G-APD Cherenkov Telescope.
http://sfb876.tu-dortmund.de/FACT/
GNU General Public License v3.0
6 stars 1 forks source link

Add new default gain file for MCs simulated with ceres 12 #336

Closed jebuss closed 6 years ago

jebuss commented 6 years ago

Rerunning the single pe analysis on simulated closed shutter pedestal files from ceres_12 revealed that the default gains used in fact.src.resources.defaultIntegralGains.csv (242 mV 0.5 ns) are not correct anymore.

This adds a calibration file with gains according to a single pe analysis on pedestal simulations with ceres_12. Entries are the median of all 1440 pixels (except for the 12 broken pixels), rounded to zero digits.

The result of the spe analysis was:

mean/median = 266.0 mV 0.5 ns std = 8.0 mV 0.5 ns

jebuss commented 6 years ago

@MaxNoe I guess we also want to change the path in the gain service, so I modified it accordingly.

jebuss commented 6 years ago

@MaxNoe please have a look. Anything else missing?

maxnoe commented 6 years ago

Tests are failing

maxnoe commented 6 years ago

Should we remove the old file?

jebuss commented 6 years ago

Should we remove the old file?

I think we should keep them side by side for a while, until we could show that things got better with the new gain file. Right now, old mc gain file and old data gain file is the combination with the smallest mismatch. Maybe it would even be good if you can choose the file for the gain service. However, the old file can be deleted once improvement has been proven.

maxnoe commented 6 years ago

I added the possibility to select the mc gain file