search

fact-project / fact-tools

The fact-tools are an extension to the streams framework to analyse the data of the First G-APD Cherenkov Telescope.
http://sfb876.tu-dortmund.de/FACT/
GNU General Public License v3.0
6 stars 1 forks source link

Fix zfits boardtime #390

Closed maxnoe closed 5 years ago

dneise commented 5 years ago

Is the fact that the buffer was not advanced a bug in get() ?

maxnoe commented 5 years ago

No, as documented in #389, the calls to asXXXXBuffer create a new view, that by design has an independent position. So this is the intended behaviour. We just used it wrong.

dneise commented 5 years ago

Ah I missed that link to the documentation .. so this was wrong all the time and in all the places you fixed it ... and it was never realized. ... that is ... somehow depressing.

kbruegge commented 5 years ago

No, as documented in #389, the calls to asXXXXBuffer create a new view, that by design has an independent position. So this is the intended behaviour. We just used it wrong.

Aha. That's surprising.

kbruegge commented 5 years ago

Can we advance the buffer by hand? We replaced all those loops a while ago on purpose.

maxnoe commented 5 years ago

Replaced the loops with reading into arrays by directly putting the correct buffer views into the tile cache.